Review Request 117146: Remove unused dependencies

[Michael Palimaka]

> On March 29, 2014, 12:02 a.m., Aleix Pol Gonzalez wrote:
> > src/kdeui/kglobalsettings.cpp, line 61
> > <https://git.reviewboard.kde.org/r/117146/diff/1/?file=258003#file258003line61>
> >
> >     Why comment it? We either need it or don't need it...

I did this so that it's "there but not there", like the ifdefd out code that was the xcb consumer.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117146/#review54518
-----------------------------------------------------------


On March 28, 2014, 6:55 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117146/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> * Comment out xcb include, since its only usage is ifdefd out
> * Remove KF5 dependencies that are not used
> * The KF5::ItemViews link was only indirectly used to link against KIO, but that's fixed there now
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc 
>   src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe 
>   src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 
> 
> Diff: https://git.reviewboard.kde.org/r/117146/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140329/2f6106fe/attachment.html>