Review Request 117148: use renamed kf5_entry.desktop file

David Faure faure at kde.org
Sat Mar 29 07:43:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117148/#review54526
-----------------------------------------------------------


No, no. This is a language entry.desktop file, not a country desktop file. Only the latter come from kde-runtime (and those are the ones you renamed). The former come from the translations.

The i18n/l10n naming confusion doesn't help, I admit.

(kde-l10n = new style = l10n means translating into a language, was called i18n before;  kde-runtime/l10n = old style = l10n means adapting to a country)

- David Faure


On March 28, 2014, 7:22 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117148/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 7:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> entry.desktop got renamed, use the renamed file 
> https://git.reviewboard.kde.org/r/117087/
> 
> 
> Diffs
> -----
> 
>   src/klanguagebutton.cpp 9f0c055 
> 
> Diff: https://git.reviewboard.kde.org/r/117148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140329/337d3564/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list