Moving KPlugionLoader|Factory to KCoreAddons?

David Faure faure at kde.org
Sat Mar 29 06:50:20 UTC 2014


On Saturday 29 March 2014 00:38:36 Alex Merry wrote:
> While doing work on KService, I realised that KPluginLoader,
> KPluginFactory and KExportPlugin could all quite happily go in
> KCoreAddons, and it would be really nice to have them there
> (KPluginTrader would stay in KService, of course).
> 
> I'm not sure of the BCness or SCness of this, though.  I think it might
> be BC, since KService links to KCoreAddons.  We'd have to include
> KCoreAddons in KService's link interface, since kservice.h uses
> KPluginLoader and KPluginFactory in a template method, so I think it
> would also be SC.
> 
> If that's the case (the SCness in particular), does that move seem
> reasonable?

Yes, this sounds SC indeed, and it makes sense in order to reduce 
dependencies. Go ahead.

One thing will not be SC though: you'll have to remove this include:
kpluginfactory.h:30:#include <ksharedconfig.h> // for source compat

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list