Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Mar 28 18:51:19 UTC 2014
> On March 28, 2014, 4:16 p.m., Commit Hook wrote:
> > This review has been submitted with commit a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch master.
>
> Aleix Pol Gonzalez wrote:
> Why did you ignore my comment? This breaks entry.desktop files usage.
>
> Jonathan Riddell wrote:
> Sorry I was wanting to get it in for the KF5 beta, I'll post a patch for kde-runtime shortly, anything else I should be updating?
>
There's a list of uses of these files in this thread:
https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg11839.html
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117087/#review54467
-----------------------------------------------------------
On March 28, 2014, 4:16 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117087/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 4:16 p.m.)
>
>
> Review request for KDE Frameworks and Chusslove Illich.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> stop clashing files on install with kdelibs4 and rename entry.desktop to kf5_entry.desktop
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 307cafa
> src/kdecore/klocale_kde.cpp d1bedee
>
> Diff: https://git.reviewboard.kde.org/r/117087/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/b3af061a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list