Review Request 117134: Use QLocale to list all languages

Aleix Pol Gonzalez aleixpol at kde.org
Fri Mar 28 18:43:22 UTC 2014



> On March 28, 2014, 3:51 p.m., David Faure wrote:
> > Same problem as https://git.reviewboard.kde.org/r/117132/ :
> > this code is supposed to list the available translations. The new code doesn't do that.
> > 
> > Is was using entry.desktop, maybe it can look up myapp.gmo files instead. But it has to be based on what is actually installed.

Not really, it's looking up all languages (as they are installed by kde-runtime).

All users should have all entry.desktop files, not only the ones that you have available for translation, AFAIU.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117134/#review54465
-----------------------------------------------------------


On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117134/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 11:50 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages.
> 
> Anybody knows if bcp47 compatible with our language naming scheme yet?
> 
> 
> Diffs
> -----
> 
>   src/klanguagebutton.cpp 9f0c055 
> 
> Diff: https://git.reviewboard.kde.org/r/117134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/d2cb0358/attachment.html>


More information about the Kde-frameworks-devel mailing list