Review Request 117145: Make ItemViews a public dependency
David Faure
faure at kde.org
Fri Mar 28 18:25:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117145/#review54483
-----------------------------------------------------------
Ship it!
True.
Too bad, though, that the cmake-level Config file looks for all deps --- even if someone only needs KIOCore...
- David Faure
On March 28, 2014, 6:24 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117145/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 6:24 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> It's required by kdirsortfilterproxymodel which is publicly available.
>
>
> Diffs
> -----
>
> KF5KIOConfig.cmake.in f4395a1f461c9aee74d85baba7c81aab19a7fea5
> src/filewidgets/CMakeLists.txt 680b48c9941ed23d818432fbdf8c9402976ba946
>
> Diff: https://git.reviewboard.kde.org/r/117145/diff/
>
>
> Testing
> -------
>
> kde4support builds against it without needing to explicitly try to link against ItemViews which is otherwise not needed there.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/337d6f8d/attachment.html>
More information about the Kde-frameworks-devel
mailing list