Review Request 117112: Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117112/
-----------------------------------------------------------

(Updated March 28, 2014, 5:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
-------

Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

KPluginLoader was overloading various non-virtual methods, which is a
dangerous business.  It probably wouldn't have resulted in any bugs that
were *too* serious, other than some possibly mismatched plugin names if
you managed to call setFileName, but it's best to do these things
properly.


While SIC, this should not affect anyone who was using KPluginLoader sensibly, ie: it should only be an issue if you did
QPluginLoader *loader = new KPluginLoader("foo")


Diffs
-----

  src/plugin/kpluginloader.h 56b3e8b9fd8e143fed16be1575c6bf2e5c979285 
  src/plugin/kpluginloader.cpp 6d831ac9681e9b26e4644a9e4771eb24c545dac7 

Diff: https://git.reviewboard.kde.org/r/117112/diff/


Testing
-------

Builds, tests pass.  I intend to extend the KPluginLoader test, but I thought I'd get the review up since time is tight before beta1.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/b0c135ab/attachment.html>