Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[David Faure]

> On March 28, 2014, 2:13 p.m., David Faure wrote:
> > How does findExecutable() help at all? You plan on adding libexec to your $PATH?
> 
> Aleix Pol Gonzalez wrote:
>     KStandardDirs::findExe used to look into libexec, IIRC.
>     
>     Maybe we could make it work.
>     Or do something completely different.

Yes. So? This uses QStandardPaths, not KStandardDirs. So the patch doesn't work.

See thread about libexec on k-f-d.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review54443
-----------------------------------------------------------


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> -------
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 3rd party software (kde-runtime), it should not make assumptions regarding location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch it's possible for distributions to ship KDE Frameworks in normal prefix (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -----
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> -------
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/53a8ce4c/attachment-0001.html>