Review Request 117122: Cut the dependency between country files and KIO

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117122/#review54458
-----------------------------------------------------------

Ship it!


For the curious like me, see git show 8ec9cef7c68d2d995ceb85aa51839762b4406025 in kdelibs for the full story behind this. But if nobody ever used it, it proves that it can be removed indeed.

- David Faure


On March 27, 2014, 6:42 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117122/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 6:42 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and John Layt.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> I was going through the kde-runtime localization thread again [1] and decided to start looking into it.
> 
> As Albert pointed out, there's many modules making use of these, one would be KIO. I looked into the actual dependency and saw that it's rather small so decided to just drop it.
> 
> In this case it's using the country/entry.desktop file to check what binary format to use, but then it seems like no entry.desktop file is specifying it [2], so it's a bit of an absurd configuration settings. I just changed it to stop reading the value.
> 
> [1] https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg11839.html
> [2]
> ~/kde5/share/locale/l10n$ grep -R BinaryUnitDialect
> C/entry.desktop:BinaryUnitDialect=0
> 
> 
> Diffs
> -----
> 
>   src/core/global.cpp 99ab2e7 
> 
> Diff: https://git.reviewboard.kde.org/r/117122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/a561b536/attachment.html>