Review Request 117137: Remove use of KPluginFactory::componentName()

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117137/#review54457
-----------------------------------------------------------


This review has been submitted with commit 3d717fac6356c38748aa905d852f43a628ed6185 by Alex Merry to branch master.

- Commit Hook


On March 28, 2014, 3:07 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117137/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 3:07 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Remove use of KPluginFactory::componentName()
> 
> This path would never have succeeded, as plugins do not have component
> data compiled into them any more.  Go straight to using the information
> from KPluginInfo instead.
> 
> 
> Diffs
> -----
> 
>   src/kpluginselector.cpp 34e4a83325e52babae4d28691abaf90f3576f379 
> 
> Diff: https://git.reviewboard.kde.org/r/117137/diff/
> 
> 
> Testing
> -------
> 
> KCMUtils now builds with https://git.reviewboard.kde.org/r/117074/ applied to kservice.  No unit tests :-(
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/0c41416a/attachment.html>