Review Request 117019: Remove fake defaultMimetype entries from protocols files
David Faure
faure at kde.org
Fri Mar 28 14:08:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117019/#review54441
-----------------------------------------------------------
You should probably test your assumption, by locally applying the same patch to your KDE4 installation, and testing these URIs.
Actually I wonder what these files are really good for, since they don't refer to any executable ("helper") or kioslave. Check the logs, if you can't find any helper or slave...
- David Faure
On March 24, 2014, 1:51 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117019/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 1:51 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> While looking into the issue, I turned up https://git.reviewboard.kde.org/r/101231/. So, this removes defaultMimetype entries referencing fake types which are apparently not actually required (I assume this is still true).
>
>
> Diffs
> -----
>
> src/ioslaves/protocols/rtspu.protocol 9cc9299f6bbe9dedb3103ff0d08f1f495428754e
> src/ioslaves/protocols/rtspt.protocol 9e4fe96261e9e6477f2f61801928394678a38fb4
> src/ioslaves/protocols/pnm.protocol 3ca3a7d23e961171caca0647ee2a23a2e3fba722
> src/ioslaves/protocols/mmsu.protocol deda935fc51235be1fea0ff96ac6c5739759817c
> src/ioslaves/protocols/mmst.protocol 1f0f7636b7647b0853a10e50d51ecf4b33be441e
> src/ioslaves/protocols/mms.protocol 79599ead181c9e6ee90eca08f09a097caee98c21
>
> Diff: https://git.reviewboard.kde.org/r/117019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/a1609681/attachment.html>
More information about the Kde-frameworks-devel
mailing list