Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()
David Gil Oliva
davidgiloliva at gmail.com
Thu Mar 27 22:30:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/
-----------------------------------------------------------
(Updated March 27, 2014, 10:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kcompletion
Description
-------
Deprecate reset() and substitute it for resetIndex().
Remove private reset() and move the implementation to the public reset()
Move method to public Q_SLOTS section
Diffs
-----
autotests/kcombobox_unittest.cpp 1479ae2
src/khistorycombobox.h d1f5eac
src/khistorycombobox.cpp 80261ae
Diff: https://git.reviewboard.kde.org/r/116969/diff/
Testing
-------
It builds. Tests pass.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/5280a293/attachment.html>
More information about the Kde-frameworks-devel
mailing list