Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in
Alexander Richardson
arichardson.kde at googlemail.com
Thu Mar 27 19:03:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116984/#review54361
-----------------------------------------------------------
Ship it!
Seems to work
- Alexander Richardson
On March 22, 2014, 9:46 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116984/
> -----------------------------------------------------------
>
> (Updated March 22, 2014, 9:46 p.m.)
>
>
> Review request for KDE Frameworks and Alexander Richardson.
>
>
> Repository: kinit
>
>
> Description
> -------
>
> Fix configuring of kde5init_win32lib_dummy.cpp.in
>
> The code referred to a variable that was no longer set, so couldn't
> possibly produce correct code. This sets the variable again (and
> renames it).
>
>
> Diffs
> -----
>
> KF5InitMacros.cmake dddc230341cfb481955a9308e1b4700aa335f940
> kde5init_win32lib_dummy.cpp.in 0c030adb0835a291d98ac91b558a08f50f0d448a
>
> Diff: https://git.reviewboard.kde.org/r/116984/diff/
>
>
> Testing
> -------
>
> Completely untested, as I don't use Windows.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/86c04fe7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list