Review Request 116998: Remove reference to KDE4_BUILD_TESTS CMake option
Commit Hook
null at kde.org
Thu Mar 27 16:08:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116998/#review54331
-----------------------------------------------------------
This review has been submitted with commit f3026925ac9421346054a2c7c514fc254f8aef2b by Alex Merry to branch master.
- Commit Hook
On March 25, 2014, 3:44 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116998/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 3:44 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Remove reference to KDE4_BUILD_TESTS CMake option
>
>
> Clean up comments about KConfig
>
>
> Fix KUrl->QUrl porting
>
> QUrl::setPath() does not behave like KUrl::setPath(). Also removed two
> very old FIXMEs: the purpose of the condition is clear now (but it was
> probably unnecessary when it used KUrl from kdelibs4), and no-one
> noticed any issues with the icon URLs during KDE 4, so KUrl probably did
> behave as expected.
>
> Remove completely out-of-date README.kdxs
>
>
> Diffs
> -----
>
> docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e
> src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224
> src/staticxml/staticxmlprovider.cpp 56a25654a70a3628573d85adf4a1c49010f23309
> src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1
> tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852
>
> Diff: https://git.reviewboard.kde.org/r/116998/diff/
>
>
> Testing
> -------
>
> Builds, installs.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/ea079141/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list