Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117104/#review54326
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 26, 2014, 11:15 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117104/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore
> 
> From the comment, I understand that formerly the clipboard changed to the contents of the KLineEdit after using clear(). I wrote a little stupid program and checked that the clipboard doesn't change using QLineEdit::clear(). Did I understand correctly?
> 
> 
> Diffs
> -----
> 
>   src/klineedit.h ca7e105 
>   src/klineedit.cpp f417902 
> 
> Diff: https://git.reviewboard.kde.org/r/117104/diff/
> 
> 
> Testing
> -------
> 
> It builds. The clipboard doesn't change.
> 
> 
> File Attachments
> ----------------
> 
> kline.h
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/26/fdc5ab2a-01ab-4fec-b88a-8c694d562da9__kline.h
> kline.cpp
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/26/9e4e8cc1-c7d5-4b72-9058-5475a8ac94b9__kline.cpp
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/4bffacf3/attachment.html>