Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117074/#review54318
-----------------------------------------------------------


Sounds good to me but I'd like David to have a look at it.

- Kevin Ottens


On March 26, 2014, 4:05 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117074/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 4:05 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> KPluginFactory: remove argumented contructor and componentName()
> 
> The Qt plugin system does not pass any arguments to its root object, so
> the component name will never get set in normal use.  So there's no
> point having a method to return it, or in accepting it in the
> constructor.
> 
> This was the oddly-ported version of a method that returned a
> KComponentData, and did not exist in kdelibs 4, hence it is being
> removed rather than deprecated.
> 
> KDE_NO_DEPRECATED -> KSERVICE_NO_DEPRECATED
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.h 821a1b1fba3cb8624e415b6fd07f65ba2739b286 
>   src/services/kplugininfo.cpp c48bd5e39ddb597256a269701cfd8efcc5328989 
>   src/sycoca/ksycoca.h aa4b31c87c79e8182191851b161c0236e2fb35ce 
>   src/sycoca/ksycoca.cpp 0b014e0921e0f0a89dbd6ea8da3950c1f0bbcc25 
>   src/kdeinit/ktoolinvocation.h 42d327fa8b651f7e1531505994d1fce202f437cd 
>   src/kdeinit/ktoolinvocation.cpp c0d5fde4e1791c114b13fe9f3ce21b97356c661b 
>   src/plugin/kexportplugin.h 15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd 
>   src/plugin/kpluginfactory.h 5d939999b5f8f73ff49baabb516b991e96d6bd8a 
>   src/plugin/kpluginfactory.cpp cf71906d47aba4decca7d261d84ca1cb67913e7e 
>   src/plugin/kpluginfactory_p.h 103ae5029e508e22c99a727ef5b7568269ba7580 
> 
> Diff: https://git.reviewboard.kde.org/r/117074/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/83618b12/attachment.html>