Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

Kevin Ottens ervin at kde.org
Thu Mar 27 15:47:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review54308
-----------------------------------------------------------



src/kjsembed/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117012/#comment37992>

    Agreed, that should be the preferred way.
    
    Note that some other frameworks probably carry the same mistake


- Kevin Ottens


On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117012/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 1:33 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> -------
> 
> Currently kjsembed CMake file tries to install both ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not allowed in a case-insensitive filesystem, causing the install step to fail on Windows.
> 
> 
> Diffs
> -----
> 
>   src/kjsembed/CMakeLists.txt e0ab74c 
> 
> Diff: https://git.reviewboard.kde.org/r/117012/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2013
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/7b4e191c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list