Review Request 117052: Add ECMSetupQtTranslations

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/
-----------------------------------------------------------

(Updated March 27, 2014, 4:26 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

- Make CREATE_LOADER take a variable name as argument.
- Introduce DATA_INSTALL_DIR argument, sets to ${DATA_INSTALL_DIR} if defined, falls back to "share" if not.
- Rename INSTALL_SUB_DIR to DATA_INSTALL_SUB_DIR.


Repository: extra-cmake-modules


Description
-------

This simplifies translation handling for frameworks using Qt translation system.


Diffs (updated)
-----

  modules/ECMSetupQtTranslations.cmake PRE-CREATION 
  modules/ECMTrLoader.cpp.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117052/diff/


Testing
-------

Here is a patch which make kbookmarks use it: http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the Messages.sh part of the patch are being reviewed for inclusion in the l10n-kde4 repository.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/8ffebffd/attachment-0001.html>