Review Request 117102: Remove unused methods from KStartupInfo

[Alex Merry]

> On March 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > Looks good to me if the other review gets accepted.

Well, if you review it... *hint, hint* :-P


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117102/#review54287
-----------------------------------------------------------


On March 26, 2014, 10:55 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117102/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 10:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Remove unused methods from KStartupInfo
> 
> These were related to the startup notification handling of KApplication,
> which is now dealt with by the xcb Qt plugin.
> 
> 
> According to LXR, nothing uses disableAutoAppStartedSending, and only KApplication and KUniqueApplication in kde4support use handleAutoAppStartedSending (see the RR this depends on).
> 
> I'm not exactly sure what to do with the other application-side (as opposed to workspace-side) startup notification things in that class.  We probably want to query the xcb plugin, and we probably want to retain the ability to manually remove notifications after startup.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.h 9c7cf80ea71f639921f2ea42ee9c748284900a3e 
>   src/kstartupinfo.cpp 605dca286c02666fdcd2825bcb0543c3865695b4 
> 
> Diff: https://git.reviewboard.kde.org/r/117102/diff/
> 
> 
> Testing
> -------
> 
> Builds, kstartupinfo test passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/70bc14f5/attachment-0001.html>