Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder

Christoph Feck christoph at maxiom.de
Thu Mar 27 12:13:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117108/#review54289
-----------------------------------------------------------


To answer my own question: probably not, because the functions are used to access a property.


src/widgets/ktextedit.cpp
<https://git.reviewboard.kde.org/r/117108/#comment37983>

    This variable can be removed.


- Christoph Feck


On March 27, 2014, 10:08 a.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117108/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 10:08 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ktextwidgets
> 
> 
> Description
> -------
> 
> Deprecate clickmessage and use QTextEdit placeholder.
> 
> We lose ability to put text in italic.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ktextedit.h 36786bb 
>   src/widgets/ktextedit.cpp 9bc8b58 
> 
> Diff: https://git.reviewboard.kde.org/r/117108/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140327/bdd8f262/attachment.html>


More information about the Kde-frameworks-devel mailing list