Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/
-----------------------------------------------------------

(Updated March 26, 2014, 5:05 p.m.)


Review request for KDE Frameworks.


Repository: kservice


Description (updated)
-------

Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

Using KSERVICE_EXPORT causes errors on Windows since it expands to
__declspec(dllimport) or __declspec(dllexport) depending on whether it is
being build or the header is being used. Since we are not building KService
when K_EXPORT_PLUGIN_VERSION is being used we get the following error:
error C2491: 'kde_plugin_version' : definition of dllimport data not allowed


Diffs
-----

  src/plugin/kexportplugin.h 15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd 

Diff: https://git.reviewboard.kde.org/r/117089/diff/


Testing
-------

compiles now


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140326/afcf90df/attachment.html>