Review Request 117058: plasma-nm CMake fixes

Alex Merry alex.merry at kde.org
Wed Mar 26 14:14:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117058/#review54201
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On March 25, 2014, 3:48 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117058/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 3:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Don't find frameworks that are not required for compilation
> 
> ----------------------------------------------------------
> 
> Also search CMAKE_PREFIX_PATH for the pkgconfig files
> 
> This will be the default behaviour when requiring CMake >= 3.1
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 
> 
> Diff: https://git.reviewboard.kde.org/r/117058/diff/
> 
> 
> Testing
> -------
> 
> Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140326/6840025e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list