Review Request 117080: cleanup KDirModelTest

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117080/#review54177
-----------------------------------------------------------



autotests/kdirmodeltest.cpp
<https://git.reviewboard.kde.org/r/117080/#comment37871>

    Do you really have to make defines for those signals? Sure, it looks fancy in the connect lines, but i personally prefer just &KDirLister::completed and &KDirLister::canceled.
    
    Perhaps others think differently?



autotests/kdirmodeltest.cpp
<https://git.reviewboard.kde.org/r/117080/#comment37872>

    You are also cleaning this one up in the cleanup() function, right?
    
    You might be fine removing this line in that case.



autotests/kdirmodeltest.cpp
<https://git.reviewboard.kde.org/r/117080/#comment37873>

    same as previous



autotests/kdirmodeltest.cpp
<https://git.reviewboard.kde.org/r/117080/#comment37874>

    same as previous



autotests/kdirmodeltest.cpp
<https://git.reviewboard.kde.org/r/117080/#comment37875>

    same as previous


As a general suggestion for those event loops and signal spy's. I don't know if this suggestion makes sense for KIO in test cases, but you "might" be able to prevent some (or all) event loops by using a lambda in the connect line: http://qt-project.org/wiki/New_Signal_Slot_Syntax#2f49cd0d473b52e6ddb8b377a34e6c36

I know this works well for listing entries, but i don't know if this works as a test case.

- Mark Gaiser


On March 26, 2014, 12:13 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117080/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 12:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Use Qt5 new signal slot syntax for KDirModelTest
> 
> This allows removing #define connect(...) QVERIFY(QObject::connect(...)),
> since now the connections are checked at compile time.
> Also removed all disconnect calls at the end of a test, now this is done
> in cleanup() which is automatically called after each test case
> 
> Always use QTestEventLoop (as is the case now already)
> 
> This merely removes the #define and #ifdefs for it
> 
> 
> Diffs
> -----
> 
>   autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e 
>   autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c 
> 
> Diff: https://git.reviewboard.kde.org/r/117080/diff/
> 
> 
> Testing
> -------
> 
> Test still passes (except for testFontUrlWithHost, but that has always timed out for me)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140326/c45c9db6/attachment.html>