Review Request 117023: Use the full path for kconf_update when running it
Alex Merry
alex.merry at kde.org
Tue Mar 25 10:23:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117023/
-----------------------------------------------------------
(Updated March 25, 2014, 10:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kconfig
Description
-------
Use the full path for kconf_update when running it
It is not on $PATH, so we cannot just expect QProcess to find it.
Export the location of kconf_update in CMake
This is for the benefit of kded, which needs to run this binary.
Diffs
-----
src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c
src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5
src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669
Diff: https://git.reviewboard.kde.org/r/117023/diff/
Testing
-------
Builds, installs. Checked the define passed to the compiler by eye. Not sure how to test the actual code.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/ab3c5490/attachment.html>
More information about the Kde-frameworks-devel
mailing list