Review Request 116997: Cleanup KDE 4 references in various comments and dox
Alex Merry
alex.merry at kde.org
Tue Mar 25 10:12:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116997/
-----------------------------------------------------------
(Updated March 25, 2014, 10:11 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kio
Description
-------
Cleanup KDE 4 references in various comments and dox
Remove commented-out KSocks call
No-one noticed its absense through KDE 4...
Remove disabled archive support from ListJob
According to the comments, this has never worked.
Remove the kdestop integration code from fileundomanager
This hasn't worked since KDE 2.1(!)
Diffs
-----
src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e
src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba
src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be
src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f
src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d
src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491
src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9
src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66
src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88
src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4
src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc
src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1
src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde
src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128
src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053
src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c
src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd
src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4
Diff: https://git.reviewboard.kde.org/r/116997/diff/
Testing
-------
Builds, compiles, tests pass.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/a46fa810/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list