Review Request 117037: Refactor parameter names

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 25 00:30:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/#review54052
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 24, 2014, 11:17 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117037/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 11:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Refactor parameter names
>     
> Also add #ifndef KCOMPLETION_NO_DEPRECATED around the implementation of KLineEdit::setUrlDropsEnabled()
> 
> 
> Diffs
> -----
> 
>   src/kcombobox.h 80d6573 
>   src/kcombobox.cpp cbb209e 
>   src/kcompletion.h 3b3b0a6 
>   src/kcompletion.cpp 847cff3 
>   src/kcompletionbox.h f396746 
>   src/kcompletionbox.cpp 7753643 
>   src/khistorycombobox.h d1f5eac 
>   src/khistorycombobox.cpp 80261ae 
>   src/klineedit.h 723cb42 
>   src/klineedit.cpp b426767 
>   src/klineedit_p.h 397abc2 
> 
> Diff: https://git.reviewboard.kde.org/r/117037/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140325/21fe9109/attachment.html>


More information about the Kde-frameworks-devel mailing list