Review Request 116930: Fix "device not open" warning messages at build time
Kevin Ottens
ervin at kde.org
Mon Mar 24 19:09:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/#review54018
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On March 23, 2014, 8:12 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116930/
> -----------------------------------------------------------
>
> (Updated March 23, 2014, 8:12 p.m.)
>
>
> Review request for KDE Frameworks and Sebastian Kügler.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> The "device not open" message appears when one registers a factory without a .json file.
> The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:
>
> class MyPlugin : public KPluginFactory
> {
> Q_OBJECT
> Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE "")
>
> When moc parses such code, it tries to read a json file named "" and rightfully complains.
>
>
> Diffs
> -----
>
> src/plugin/kpluginfactory.h 3880d29
>
> Diff: https://git.reviewboard.kde.org/r/116930/diff/
>
>
> Testing
> -------
>
> Rebuilt kde-workspace from scratch. No more message.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/12fb64e4/attachment.html>
More information about the Kde-frameworks-devel
mailing list