Review Request 116999: kparts: Remove/resolve old porting comments and TODOs

Kevin Ottens ervin at kde.org
Mon Mar 24 19:07:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116999/#review54016
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 23, 2014, 4:33 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116999/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Remove old porting comments and TODOs
> 
> 
> Use QMetaObject::indexOfMethod instead of iterating through methods
> 
> 
> Diffs
> -----
> 
>   src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a 
>   src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 
>   src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 
>   src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 
> 
> Diff: https://git.reviewboard.kde.org/r/116999/diff/
> 
> 
> Testing
> -------
> 
> builds, installs, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/a9107c07/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list