Review Request 116982: Remove KDE 4 refs in khtml

Kevin Ottens ervin at kde.org
Mon Mar 24 18:59:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116982/#review54013
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 22, 2014, 6:46 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116982/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 6:46 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Add FIXME to testregression docs about updating them
> 
> 
> kcmshell4 -> kcmshell5
> 
> 
> Reword or resolve "### KDE4" TODOs
> 
> Those that are just simple binary compatibility issues are resolved,
> others are replaced with "TODO".
> 
> 
> Diffs
> -----
> 
>   src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f 
>   src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e 
>   src/ecma/debugger/breakpointsdock.cpp 3570bd07d705e60274d1a44f6bd344b613ec64c1 
>   src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 
>   src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e 
>   src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 
>   src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 
>   src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 
>   src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 
>   src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 
>   src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f 
>   src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 
>   src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa 
>   src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad 
> 
> Diff: https://git.reviewboard.kde.org/r/116982/diff/
> 
> 
> Testing
> -------
> 
> Builds, installs, autotests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/f8b93f3a/attachment.html>


More information about the Kde-frameworks-devel mailing list