Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY

Kevin Ottens ervin at kde.org
Mon Mar 24 18:51:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116926/#review54008
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 20, 2014, 1:40 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116926/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 1:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Remove support for _NET_WM_TAKE_ACTIVITY
> 
> This was a proposed protocol [1] which never got adopted and no toolkit
> is making use of it. It's not implemented in either Qt4 or Qt5 and
> also not in GTK [2].
> 
> Only KWin had support for it, but didn't announce it in NET::Supported.
> 
> This is a SIC-change, but according to lxr nothing except KWin used
> these methods and there they are already in the process of getting
> removed.
> 
> [1] https://mail.gnome.org/archives/wm-spec-list/2004-April/msg00013.html
> [2] https://bugzilla.gnome.org/show_bug.cgi?id=154260
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp e5fb0fa2b60bf434c84f89ce5e81deb93e3d2467 
>   src/netwm.h 640686a3cf4723bfd6e5aaad0b301f86f0a463ed 
>   src/netwm.cpp d9956d2b8191405847ff84cb401126fa7a2f2fbf 
>   src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 
> 
> Diff: https://git.reviewboard.kde.org/r/116926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/cedd8a95/attachment.html>


More information about the Kde-frameworks-devel mailing list