Review Request 116876: Add default emoticons theme to kemoticons

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54006
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 18, 2014, 3:58 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116876/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> Make the autotests work uninstalled
> 
> This also makes them data-driven, separating out the different testcases
> in the output, and fixes the "skipping" behaviour (so QSKIP only skips
> one testcase and not all of them).
> 
> 
> Add a default theme
> 
> This was originally the default theme from Kopete, and was called "kde4"
> up until this point.
> 
> To trace its history, start at:
> svn path=/trunk/KDE/kdebase/runtime/; revision=699615
> which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
> kde-runtime.
> 
> 
> I didn't copy the history from kde-runtime, because there was no history to copy - only the commit noted above actually made it out of svn.
> 
> 
> Diffs
> -----
> 
>   themes/Glass/sleep.png PRE-CREATION 
>   themes/Glass/shade.png PRE-CREATION 
>   themes/Glass/rose.png PRE-CREATION 
>   themes/Glass/sad.png PRE-CREATION 
>   themes/Glass/present.png PRE-CREATION 
>   themes/Glass/phone.png PRE-CREATION 
>   themes/Glass/omg.png PRE-CREATION 
>   themes/Glass/note.png PRE-CREATION 
>   themes/Glass/oh.png PRE-CREATION 
>   themes/Glass/love.png PRE-CREATION 
>   CMakeLists.txt de080764f7d387871ebebf6bfa7541944b618036 
>   autotests/CMakeLists.txt 98b8e43b2f5cbe08dc6b454e2736e809538a0251 
>   autotests/kemoticontest.h ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5 
>   autotests/kemoticontest.cpp b7dc6f75fb722d63936fb666a51b969d37b84e31 
>   src/core/kemoticons.cpp bc72e166586ef1271cac2291a9223c2472e1d8b8 
>   tests/main.cpp 13f584a153fbd3612e8702d05368960d6e8e4e59 
>   themes/CMakeLists.txt PRE-CREATION 
>   themes/Glass/angry.png PRE-CREATION 
>   themes/Glass/bat.png PRE-CREATION 
>   themes/Glass/beer.png PRE-CREATION 
>   themes/Glass/biggrin.png PRE-CREATION 
>   themes/Glass/cake.png PRE-CREATION 
>   themes/Glass/camera.png PRE-CREATION 
>   themes/Glass/cat.png PRE-CREATION 
>   themes/Glass/clock.png PRE-CREATION 
>   themes/Glass/cocktail.png PRE-CREATION 
>   themes/Glass/confused.png PRE-CREATION 
>   themes/Glass/cry.png PRE-CREATION 
>   themes/Glass/cup.png PRE-CREATION 
>   themes/Glass/dog.png PRE-CREATION 
>   themes/Glass/email.png PRE-CREATION 
>   themes/Glass/embarassed.png PRE-CREATION 
>   themes/Glass/emoticons.xml PRE-CREATION 
>   themes/Glass/film.png PRE-CREATION 
>   themes/Glass/foot_in_mouth.png PRE-CREATION 
>   themes/Glass/innocent.png PRE-CREATION 
>   themes/Glass/kiss.png PRE-CREATION 
>   themes/Glass/lightbulb.png PRE-CREATION 
>   themes/Glass/smile.png PRE-CREATION 
>   themes/Glass/star.png PRE-CREATION 
>   themes/Glass/teeth.png PRE-CREATION 
>   themes/Glass/thumbs_down.png PRE-CREATION 
>   themes/Glass/thumbs_up.png PRE-CREATION 
>   themes/Glass/tongue.png PRE-CREATION 
>   themes/Glass/undecided.png PRE-CREATION 
>   themes/Glass/unhappy.png PRE-CREATION 
>   themes/Glass/unlove.png PRE-CREATION 
>   themes/Glass/wilted_rose.png PRE-CREATION 
>   themes/Glass/wink.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116876/diff/
> 
> 
> Testing
> -------
> 
> Builds, installs, tests pass without skipping (both before and after installation).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/ae3a4cc6/attachment.html>