Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

[Alex Merry]

> On March 23, 2014, 11:39 p.m., Aleix Pol Gonzalez wrote:
> > src/colors/kcolorutils.cpp, line 38
> > <https://git.reviewboard.kde.org/r/116866/diff/5/?file=256190#file256190line38>
> >
> >     Wouldn't it make more sense to use qIsNan?
> >     
> >     http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN

Huh.  Yes.  Doing work on KJS had me in the wrong mindset :-)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/#review53877
-----------------------------------------------------------


On March 22, 2014, 8:54 p.m., Michael Hansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116866/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 8:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> -------
> 
> Use std::isnan from <cmath> instead of isnan from <math.h>, as MinGW-32 on Windows does not include the latter.  This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(.
> 
> 
> Diffs
> -----
> 
>   src/kguiaddons_config.h.cmake PRE-CREATION 
>   src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 
>   src/ConfigureChecks.cmake PRE-CREATION 
>   src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 
> 
> Diff: https://git.reviewboard.kde.org/r/116866/diff/
> 
> 
> Testing
> -------
> 
> Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64).
> 
> 
> Thanks,
> 
> Michael Hansen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/99579681/attachment.html>