Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler
Alex Merry
alex.merry at kde.org
Mon Mar 24 11:50:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/
-----------------------------------------------------------
(Updated March 24, 2014, 11:50 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kconfig
Description
-------
Rename the kconfig_compiler_kf5 target to kconfig_compiler
Just because the executable has the "_kf5" suffix, that does not mean
the target should have it. This is ugly API, and will be unnecessary
porting effort for KF6.
Only one place uses this currently - one CMake file in kde4support. I'll change that when committing this.
Diffs
-----
CMakeLists.txt 417cd9cb7e0d80abd9100019786e8ea19007e3ef
KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309
autotests/kconfig_compiler/CMakeLists.txt 289e9583b64396c5eb080a1bc9cb2833b540ba71
src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0
Diff: https://git.reviewboard.kde.org/r/116995/diff/
Testing
-------
Builds, installs, tests pass.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/44af90da/attachment.html>
More information about the Kde-frameworks-devel
mailing list