Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

Commit Hook null at kde.org
Mon Mar 24 11:34:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/#review53951
-----------------------------------------------------------


This review has been submitted with commit b1808656b35b24eb3133dcf7e2639d111b7d1514 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 4:45 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117000/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 4:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Rename kmimetypefactory.h to kmimetypefactory_p.h
> 
> This makes it obvious it is not installed.
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kbuildmimetypefactory.h a1c9f064c95191d30f92f5911168547892150729 
>   src/kbuildsycoca/kbuildservicefactory.cpp 55b2eea17e164bd64e83860a7d42d0fa95c89b84 
>   src/services/kmimetypefactory.h 239a4cdfa2c3add603c6915ecd967401254cd930 
>   src/services/kmimetypefactory.cpp 8fedf59170e4a1af59eae726ca873288d06ea432 
>   src/services/kmimetypetrader.cpp 839579790e6624ff1856d2b5a26307d4da4f3974 
>   src/services/kservice.cpp 50c86ac1a5dfa1400f7471be48494c323005c47d 
> 
> Diff: https://git.reviewboard.kde.org/r/117000/diff/
> 
> 
> Testing
> -------
> 
> Builds, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/fe4a8959/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list