Review Request 117016: Allow overriding DrKonqi lookup directories by PATH
Dan Vrátil
dvratil at redhat.com
Mon Mar 24 10:52:19 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcrash
Description
-------
Since KCrash is a framework that relies on DrKonqi binary being provided by a 3rd party software (kde-runtime), it should not make assumptions regarding location of the utility.
This patch makes KCrash to look for drkonqi binary first in $PATH, then falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch it's possible for distributions to ship KDE Frameworks in normal prefix (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
Diffs
-----
src/kcrash.cpp 87163cc
Diff: https://git.reviewboard.kde.org/r/117016/diff/
Testing
-------
- Installed KCrash into /usr prefix
- Installed drkonqi from kde-runtime master to /opt/kde5 prefix
- started broken application
- no "could not find drkonqi" warning anymore
- crashed application, got drkonqi window
Thanks,
Dan Vrátil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140324/b6253c11/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list