Review Request 116936: Use QLibrary instead of KLibrary

David Faure faure at kde.org
Sun Mar 23 19:53:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/#review53834
-----------------------------------------------------------

Ship it!



src/html/kopenssl.cpp
<https://git.reviewboard.kde.org/r/116936/#comment37753>

    funny iterator name ;)


- David Faure


On March 20, 2014, 8:48 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116936/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 8:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Use QLibrary instead of KLibrary
> 
> This code wants to load normal libraries, rather than ones in plugin
> directories, and so does not need or want KLibrary's odd lookup
> routines.
> 
> 
> Diffs
> -----
> 
>   src/html/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a 
>   src/rendering/break_lines.cpp bc4542c7ea1031d75531b6028f3044fe15672009 
> 
> Diff: https://git.reviewboard.kde.org/r/116936/diff/
> 
> 
> Testing
> -------
> 
> ./tests/testkhtml 'https://git.reviewboard.kde.org'
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140323/205cb2db/attachment.html>


More information about the Kde-frameworks-devel mailing list