Review Request 116991: kded: Use a consistent configuration file name

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116991/#review53814
-----------------------------------------------------------

Ship it!



src/kded.cpp
<https://git.reviewboard.kde.org/r/116991/#comment37736>

    To be honest I don't like this very much, the variable bCheckSycoca suddenly changes meaning, from being the default value to being the actual value.
    I would have rather removed the file-global default values. This only creates one issue for checkStamps, but that can be solved with bool s_checkStampsDefault = true.
    
    But anyway, no big deal.


- David Faure


On March 23, 2014, 1:29 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116991/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 1:29 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Use a consistent configuration file name
> 
> Before, the initial configuration was explicitly drawn from "kdedrc",
> while autoloading stuff was drawn from the application-default file,
> which was "kded5rc".  This change makes it always use the
> application-default file, which involves rearrangeing some of the code
> to make sure the application instance always has its name set
> consistently.
> 
> This also changes the configuration entry reading so that the defaults
> are set in exactly one place.
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 
> 
> Diff: https://git.reviewboard.kde.org/r/116991/diff/
> 
> 
> Testing
> -------
> 
> Ran with some debug statements to print the value of CheckFileStamps both with and without --check.  Setting the value in ~/.config/kded5rc altered this printout.  This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140323/d9d7a462/attachment.html>