Review Request 116934: Use KPluginLoader to find kioslaves

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/
-----------------------------------------------------------

(Updated March 23, 2014, 1:51 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Use KPluginLoader::findPlugin().


Repository: kio


Description (updated)
-------

Use KPluginLoader to find kioslaves

KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than
QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of
QPluginLoader to locate them.


Diffs (updated)
-----

  src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a 
  src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e 
  src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e 

Diff: https://git.reviewboard.kde.org/r/116934/diff/


Testing (updated)
-------

Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to list /tmp.  kio_file.so was found each time.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140323/f8be3c9f/attachment.html>