Review Request 116980: Update the kded5 man page

[Alex Merry]

> On March 23, 2014, 12:15 p.m., Burkhard Lück wrote:
> > docs/kded5/man-kded5.8.docbook, line 9
> > <https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line9>
> >
> >     All other docbook man pages in frameworks have "&kde; User's Manual" here, why this change?

To reflect the branding shift away from "KDE" as a product.  The standard in other man pages appears to be to put the product there, which in this case is the KDED framework.


> On March 23, 2014, 12:15 p.m., Burkhard Lück wrote:
> > docs/kded5/man-kded5.8.docbook, line 246
> > <https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line246>
> >
> >     Are you sure <filename>~/.config/kdedrc</filename> is correct?
> >     
> >     Shouldn't kdedrc be in "kf5-config --path config"?
> >     
> >     But here it is in:
> >     /home/kdeframeworks/.kde/share/config/kdedrc

kf5-config is deprecated, and only available if kde4support is installed.

Possibly it should refer to XDG_CONFIG_HOME, since that is the variable that actually determines where it is installed on a Unix system.  The path given is the default if that does not exist.  Unless the distro has been hacking with the paths (in Qt or KConfig, I guess), of course, in which case they should also change the man page.

(Also, are you sure that's where kded5 looks, rather than where kded4 looks? kded5 does not create the file if it does not exist).


> On March 23, 2014, 12:15 p.m., Burkhard Lück wrote:
> > docs/kded5/man-kded5.8.docbook, line 263
> > <https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line263>
> >
> >     grep CheckStamps frameworks/kded -> no hit
> >     
> >     $ wcgrep CheckFileStamps frameworks/kded/
> >     frameworks/kded/README.md:62:    CheckFileStamps=true
> >     frameworks/kded/src/kded.cpp:749:        checkStamps = cg.readEntry("CheckFileStamps", true);
> >     frameworks/kded/src/kded.cpp:765:    checkStamps = cg.readEntry("CheckFileStamps", true);
> >     
> >     Should be changed to "CheckFileStamps"

Oops.  Good spot.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/#review53796
-----------------------------------------------------------


On March 22, 2014, 5:53 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116980/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 5:53 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Update the kded5 man page
> 
> 
> Diffs
> -----
> 
>   docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 
> 
> Diff: https://git.reviewboard.kde.org/r/116980/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, visually inspected man page.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140323/79467893/attachment.html>