Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

[Michael Hansen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/
-----------------------------------------------------------

(Updated March 22, 2014, 10:13 a.m.)


Review request for KDE Frameworks.


Repository: kguiaddons


Description
-------

Use std::isnan from <cmath> instead of isnan from <math.h>, as MinGW-32 on Windows does not include the latter.  This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(.


Diffs (updated)
-----

  src/kguiaddons_config.h.cmake PRE-CREATION 
  src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 
  src/ConfigureChecks.cmake PRE-CREATION 
  src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 

Diff: https://git.reviewboard.kde.org/r/116866/diff/


Testing
-------

Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64).


Thanks,

Michael Hansen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140322/2c744592/attachment.html>