Review Request 116961: Replace fake MIME type

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116961/#review53746
-----------------------------------------------------------

Ship it!


Yeah the other hits are just string comparisons for compatibility and don't need the mimetype definition.

- David Faure


On March 21, 2014, 6:07 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116961/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 6:07 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'.
> 
> There are a few other references to "all/all", "all/allfiles", and "all/" in this repo. I didn't touch them since it wasn't suggested to do so on the mailing list post, and I'm not too familiar with this code.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilefiltercombo.cpp a800b38a50a4cb3c7b89928e09b6be9d8bc19ca0 
> 
> Diff: https://git.reviewboard.kde.org/r/116961/diff/
> 
> 
> Testing
> -------
> 
> Played with some consumers of filewidgets which seems to behave normally, but again I'm not particularly familiar with what's happening here.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140322/3dc7e37f/attachment.html>