Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

David Gil Oliva davidgiloliva at gmail.com
Fri Mar 21 22:51:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Remove private reset() and move the implementation to the public reset()

Move method to public Q_SLOTS section


Diffs
-----

  src/khistorycombobox.h d1f5eac 
  src/khistorycombobox.cpp 80261ae 

Diff: https://git.reviewboard.kde.org/r/116969/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140321/bd689b4b/attachment.html>


More information about the Kde-frameworks-devel mailing list