Review Request 116886: Refactor private variables of KCompletion
Frank Reininghaus
frank78ac at googlemail.com
Fri Mar 21 16:37:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116886/#review53705
-----------------------------------------------------------
Ship it!
Looks reasonable to me, thanks!
- Frank Reininghaus
On March 19, 2014, 11:01 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116886/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:01 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Refactor private variables of KCompletion
>
> Also: reorder variables declaration to avoid padding
>
>
> Diffs
> -----
>
> src/kcompletion.cpp 7396029
> src/kcompletion_p.h e3fad26
>
> Diff: https://git.reviewboard.kde.org/r/116886/diff/
>
>
> Testing
> -------
>
> It builds. Autotests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140321/0f9817b7/attachment.html>
More information about the Kde-frameworks-devel
mailing list