Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
Michael Hansen
zrax0111 at gmail.com
Fri Mar 21 16:26:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/
-----------------------------------------------------------
(Updated March 21, 2014, 9:26 a.m.)
Review request for KDE Frameworks.
Changes
-------
Updated copyright
Repository: kguiaddons
Description
-------
Use std::isnan from <cmath> instead of isnan from <math.h>, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(.
Diffs (updated)
-----
src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92
src/ConfigureChecks.cmake PRE-CREATION
src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2
src/kguiaddons_config.h.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/116866/diff/
Testing
-------
Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64).
Thanks,
Michael Hansen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140321/c401771c/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list