Review Request 116894: Clean up comments that reference kde4
Alex Merry
alex.merry at kde.org
Fri Mar 21 10:02:25 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116894/
-----------------------------------------------------------
(Updated March 21, 2014, 10:02 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kservice
Description
-------
Clean up comments about removed syscoca type numbers
Remove "explanation" of why the desktoptojson target is exported
The explanation was wrong, and it doesn't really need any justification
anyway.
Remove comment about test finding kmailservice from KDE4
It won't find the wrong kmailservice, because the desktop file is now
called kmailservice5.
Diffs
-----
autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2
src/desktoptojson/CMakeLists.txt f106d254e015fc4eccf12fb4437ec221fb64ba1b
src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279
Diff: https://git.reviewboard.kde.org/r/116894/diff/
Testing
-------
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140321/0a418b83/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list