Review Request 116930: Fix "device not open" warning messages at build time

Aurélien Gâteau agateau at kde.org
Thu Mar 20 15:32:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kservice


Description
-------

The "device not open" message appears when one registers a factory without a .json file.
The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:

class MyPlugin : public KPluginFactory
{
    Q_OBJECT
    Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE "")

When moc parses such code, it tries to read a json file named "" and rightfully complains.


Diffs
-----

  src/plugin/kpluginfactory.h 3880d29 

Diff: https://git.reviewboard.kde.org/r/116930/diff/


Testing
-------

Rebuilt kde-workspace from scratch. No more message.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140320/06499977/attachment.html>


More information about the Kde-frameworks-devel mailing list