Review Request 116912: Remove KSocks and KSocksSocketDevice

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116912/#review53477
-----------------------------------------------------------

Ship it!


Yep, warm weather is coming, let's get rid of the socks.

- David Faure


On March 20, 2014, 12:33 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116912/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 12:33 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Remove KSocks and KSocksSocketDevice
> 
> LXR says these are entirely unused, they have been deprecated since 4.0
> and k3socks.cpp makes use of the long-deprecated KLibrary::factory()
> method.
> 
> 
> Diffs
> -----
> 
>   src/includes/CMakeLists.txt 048d474583bbbba1ce9e5f142ad3ffb4d4ccb7f3 
>   src/CMakeLists.txt 362855d1a3143a3efd74bee6a850eb11434eb517 
>   src/includes/KNetwork/KSocksSocketDevice f2b7cea900c73545d751f8b03fdcd0e46e51c659 
>   src/includes/KSocks bf29d0350fe1241820efffbdb39f72f353123a15 
>   src/kdecore/k3socketdevice.cpp da772b0196f35870ee1d87b43e4941519bcb661b 
>   src/kdecore/k3socks.h 51f8a4f2443b510b530c2afaa192271b6a6f00aa 
>   src/kdecore/k3socks.cpp 920340b14899b56b300607326e5da6fc810095b8 
>   src/kdecore/k3sockssocketdevice.h 2197ce63f2d96415da5949bdaff83a4f694eef53 
>   src/kdecore/k3sockssocketdevice.cpp dae2f75fbafbd4f1d91fb8503669220f6bf7475e 
> 
> Diff: https://git.reviewboard.kde.org/r/116912/diff/
> 
> 
> Testing
> -------
> 
> Built, installed.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140320/cf88c09e/attachment-0001.html>