Review Request 116912: Remove KSocks and KSocksSocketDevice
Alex Merry
alex.merry at kde.org
Thu Mar 20 00:14:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116912/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kde4support
Description
-------
Remove KSocks and KSocksSocketDevice
LXR says these are entirely unused, they have been deprecated since 4.0
and k3socks.cpp makes use of the long-deprecated KLibrary::factory()
method.
Diffs
-----
src/CMakeLists.txt 362855d1a3143a3efd74bee6a850eb11434eb517
src/kdecore/k3socks.h 51f8a4f2443b510b530c2afaa192271b6a6f00aa
src/kdecore/k3socks.cpp 920340b14899b56b300607326e5da6fc810095b8
src/kdecore/k3sockssocketdevice.h 2197ce63f2d96415da5949bdaff83a4f694eef53
src/kdecore/k3sockssocketdevice.cpp dae2f75fbafbd4f1d91fb8503669220f6bf7475e
Diff: https://git.reviewboard.kde.org/r/116912/diff/
Testing
-------
Built, installed, ran tests.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140320/75093bc6/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list