Review Request 116886: Refactor private variables of KCompletion
David Gil Oliva
davidgiloliva at gmail.com
Wed Mar 19 22:52:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116886/
-----------------------------------------------------------
(Updated March 19, 2014, 10:52 p.m.)
Review request for KDE Frameworks.
Changes
-------
Add TODO item for hasMultipleMatches variable.
Convert order variable to bitfield, following Frank's suggestion.
Repository: kcompletion
Description
-------
Refactor private variables of KCompletion
Also: reorder variables declaration to avoid padding
Diffs (updated)
-----
src/kcompletion.cpp 7396029
src/kcompletion_p.h e3fad26
Diff: https://git.reviewboard.kde.org/r/116886/diff/
Testing
-------
It builds. Autotests pass.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140319/d06c9f85/attachment.html>
More information about the Kde-frameworks-devel
mailing list