Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116883/
-----------------------------------------------------------

(Updated March 19, 2014, 9:20 a.m.)


Review request for KDE Frameworks.


Changes
-------

Changed from shouldStop function to maxCount parameter since std::function is always an indirect call
Use std::function for the callback (indirect call doesn't matter that much there).


Repository: kcoreaddons


Description
-------

Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

The gr_mem member of struct group does not contain the names of users
where the primary group is equal to that group. In order to fix this we
have to iterate over all users and check whether the primary gid matches
the requested group. Unlike getgrouplist() there does not seem to be a
function that performs this task for us.


Diffs (updated)
-----

  autotests/kusertest.cpp 369bd56cbba4554b04c03847b74fb023a426f5eb 
  src/lib/util/kuser_unix.cpp 0e0720dbb614015d6d568b39da3cab77cece76a8 

Diff: https://git.reviewboard.kde.org/r/116883/diff/


Testing
-------

Listed groups seem to be correct now. Should fix Jenkins together with https://git.reviewboard.kde.org/r/116881/


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/18/871c8bc5-4631-4759-8103-eb7ac817d698__groupmembers_before.txt
After
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/18/4295e719-acb8-495f-907b-5a93d2d8b64f__groupmembers_after.txt


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140319/905bfaca/attachment.html>